Skip to content

BUG: do not suppress errors when closing file handles #47165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2022
Merged

BUG: do not suppress errors when closing file handles #47165

merged 2 commits into from
May 30, 2022

Conversation

twoertwein
Copy link
Member

Wait for #47153 to be merged (fails on main otherwise). Closes #47136 and should be backported #47153 (comment)

@twoertwein twoertwein added IO Data IO issues that don't fit into a more specific label Error Reporting Incorrect or improved errors from pandas labels May 29, 2022
@twoertwein twoertwein added this to the 1.4.3 milestone May 29, 2022
@twoertwein twoertwein marked this pull request as ready for review May 30, 2022 12:46
@twoertwein
Copy link
Member Author

@simonjayhawkins green

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twoertwein lgtm.

@jreback jreback merged commit 96ba36d into pandas-dev:main May 30, 2022
@jreback
Copy link
Contributor

jreback commented May 30, 2022

thanks @twoertwein

@jreback
Copy link
Contributor

jreback commented May 30, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 30, 2022

Could not push to auto-backport-of-pr-47165-on-1.4.x due to error, aborting.

jreback pushed a commit that referenced this pull request Jun 1, 2022
@twoertwein twoertwein deleted the close branch June 8, 2022 19:26
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas IO Data IO issues that don't fit into a more specific label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas should not swallow exceptions when close()ing a write handle
3 participants