Skip to content

DOC: how to_datetime %S differs from strptime #47164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: how to_datetime %S differs from strptime #47164

wants to merge 1 commit into from

Conversation

MaruthiKo
Copy link
Contributor

@MaruthiKo MaruthiKo commented May 29, 2022

If any other changes are required please let me know.

If any other changes are required please let me know.
@pep8speaks
Copy link

Hello @MaruthiKo! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 776:68: W291 trailing whitespace
Line 778:27: W291 trailing whitespace
Line 780:54: W291 trailing whitespace

@MarcoGorelli MarcoGorelli changed the title Required changes in documentation as #47134 DOC: how to_datetime %S differs from strptime May 29, 2022
up to nanoseconds.
:const:`"%S"` without :const:`"%f"` will capture up to
nanoseconds if present as decimal places, but
will also handle the case where the number of seconds is an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an example which illustrates this case (or both)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If u don't mind, Can u help me with how I can add an example?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add another section in the same docstring. See this document: https://numpydoc.readthedocs.io/en/latest/format.html#examples

Note that the order of sections is important. You can check other docstrings in the pandas docs for samples, and to check which data we usually use...

Also, the CI is red because of black. You can run black before committing, and check the contributing docs for further information: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 17, 2022
@datapythonista
Copy link
Member

Closing as stale. Please let us know if you want to continue workion this and add the examples @MaruthiKo

@MaruthiKo
Copy link
Contributor Author

Closing as stale. Please let us know if you want to continue workion this and add the examples @MaruthiKo

Carry on, I have not found any other examples to add on

@MarcoGorelli
Copy link
Member

No worries, thanks anyway for your PR

@MarcoGorelli MarcoGorelli added this to the No action milestone Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: how to_datetime %S differs from strptime
6 participants