-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: how to_datetime %S differs from strptime #47164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If any other changes are required please let me know.
Hello @MaruthiKo! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
up to nanoseconds. | ||
:const:`"%S"` without :const:`"%f"` will capture up to | ||
nanoseconds if present as decimal places, but | ||
will also handle the case where the number of seconds is an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add an example which illustrates this case (or both)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If u don't mind, Can u help me with how I can add an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add another section in the same docstring. See this document: https://numpydoc.readthedocs.io/en/latest/format.html#examples
Note that the order of sections is important. You can check other docstrings in the pandas docs for samples, and to check which data we usually use...
Also, the CI is red because of black. You can run black before committing, and check the contributing docs for further information: https://pandas.pydata.org/pandas-docs/stable/development/contributing.html
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Closing as stale. Please let us know if you want to continue workion this and add the examples @MaruthiKo |
Carry on, I have not found any other examples to add on |
No worries, thanks anyway for your PR |
If any other changes are required please let me know.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.