Properly propagate exceptions in sas.pyx #47149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashaag
commented
May 27, 2022
| ofs = cnt + 3 | ||
| ofs += <uint16_t>inbuff[ipos] << 4 | ||
| ipos += 1 | ||
| for k in range(cmd): | ||
| outbuff[rpos + k] = outbuff[rpos - <int>ofs + k] | ||
| rpos += cmd | ||
|
|
||
| else: |
There was a problem hiding this comment.
This case is actually impossible and I removed it so that nobody is confused why we aren't testing the raise ValueError.
mroeschke
reviewed
May 27, 2022
pandas/io/sas/sas.pyx
Outdated
| @@ -294,7 +291,7 @@ cdef class Parser: | |||
| self.parser._current_row_in_chunk_index = self.current_row_in_chunk_index | |||
| self.parser._current_row_in_file_index = self.current_row_in_file_index | |||
|
|
|||
| cdef bint read_next_page(self): | |||
| cdef read_next_page(self): | |||
There was a problem hiding this comment.
Why was the bint here removed?
There was a problem hiding this comment.
Because otherwise read_next_page doesn't propagate exceptions. Alternative could be cdef bint read_next_page(self) except * or cdef bint read_next_page(self) except 1
There was a problem hiding this comment.
The alternatives would be preferred IMO
mroeschke
reviewed
May 27, 2022
jonashaag
force-pushed
the
sasbdat-exceptions
branch
from
2a5438f to
ac4c2f1
Compare
mroeschke
approved these changes
May 31, 2022
|
thanks @jonashaag |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.