Skip to content

TYP: Upgrade mypy to 0.960 #47140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2022
Merged

TYP: Upgrade mypy to 0.960 #47140

merged 2 commits into from
May 28, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented May 27, 2022

Looks like this passed out of the box

@phofl phofl added the Typing type annotations, mypy/pyright type checking label May 27, 2022
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback
Copy link
Contributor

jreback commented May 27, 2022

how old is 0.96?

@phofl
Copy link
Member Author

phofl commented May 27, 2022

3 days, why?

@twoertwein
Copy link
Member

how old is 0.96?

mypy aims to have a monthly release cycle

@phofl
Copy link
Member Author

phofl commented May 27, 2022

Can you also update the mypy version in https://github.com/pandas-dev/pandas/blob/main/doc/source/whatsnew/v1.5.0.rst

done

@twoertwein twoertwein merged commit 578e918 into pandas-dev:main May 28, 2022
@twoertwein
Copy link
Member

Thank you @phofl

@phofl phofl deleted the upgrade_mypy branch June 6, 2022 20:49
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* TYP: Upgrade mypy to 0.960

* Update whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants