-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix SAS7BDAT run-length encoding formula #47099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
917c4da
Fix SAS7BDAT run-length encoding formula
jonashaag e8c1a0f
Undo safety change
jonashaag 828dd35
Undo unnecessary bit mask
jonashaag 0c3b80c
Undo syntax change
jonashaag 07a0ffc
Update v1.5.0.rst
jonashaag 71e8a6d
Update v1.5.0.rst
jonashaag 98d248c
Merge branch 'main' into patch-2
jonashaag 5ad2452
Add test file
jonashaag 91d868d
Fix tests
jonashaag 2df7e73
Merge branch 'main' into patch-2
jonashaag b1bcfa3
Merge branch 'main' into patch-2
jonashaag 2e06740
Merge branch 'main' into patch-2
jonashaag 76e5b55
Merge branch 'main' into patch-2
jonashaag 7c0fe16
Update test_sas7bdat.py
jonashaag 2660b05
Merge branch 'main' into patch-2
jonashaag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -390,3 +390,10 @@ def test_0x40_control_byte(datapath): | |
fname = datapath("io", "sas", "data", "0x40controlbyte.csv") | ||
df0 = pd.read_csv(fname, dtype="object") | ||
tm.assert_frame_equal(df, df0) | ||
|
||
|
||
def test_0x00_control_byte(datapath): | ||
# GH 47099 | ||
fname = datapath("io", "sas", "data", "0x00controlbyte.sas7bdat.bz2") | ||
df = next(pd.read_sas(fname, chunksize=11_000)) | ||
assert df.shape == (11_000, 20) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a review comment so I can approve. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the same note as two lines above? If so, you can just add to the issue references
(:issue:..., :issue:...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it’s a different control byte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks missed that 😅