Skip to content

Bug Fix: pd.DataFrame.sum with min_count changes dtype if result contains NaNs #47091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 29, 2022
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ Indexing
- Bug in setting large integer values into :class:`Series` with ``float32`` or ``float16`` dtype incorrectly altering these values instead of coercing to ``float64`` dtype (:issue:`45844`)
- Bug in :meth:`Series.asof` and :meth:`DataFrame.asof` incorrectly casting bool-dtype results to ``float64`` dtype (:issue:`16063`)
- Bug in :meth:`NDFrame.xs`, :meth:`DataFrame.iterrows`, :meth:`DataFrame.loc` and :meth:`DataFrame.iloc` not always propagating metadata (:issue:`28283`)
-
- Bug in :meth:`_maybe_null_out` pd.DataFrame.sum with min_count changes dtype if result contains NaNs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_maybe_null_out is private. Please reference the public functions, e.g. sum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok Have updated


Missing
^^^^^^^
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/nanops.py
Original file line number Diff line number Diff line change
Expand Up @@ -1472,7 +1472,8 @@ def _maybe_null_out(
if np.iscomplexobj(result):
result = result.astype("c16")
else:
result = result.astype("f8")
if not is_float_dtype(result):
result = result.astype("f8")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this an elif

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add copy=False

result[null_mask] = np.nan
else:
# GH12941, use None to auto cast null
Expand Down
14 changes: 14 additions & 0 deletions pandas/tests/frame/test_reductions.py
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,20 @@ def test_sum_nanops_min_count(self):
expected = Series([np.nan, np.nan], index=["x", "y"])
tm.assert_series_equal(result, expected)

@pytest.mark.parametrize(
"kwargs",
[
{"axis": 1, "min_count": 1},
{"axis": 1, "min_count": 2},
{"axis": 1, "skipna": False},
],
)
def test_sum_nanops_dtype_min_count(self, kwargs):
# GH#46947
df = DataFrame({"a": [1.0, 2.3, 4.4], "b": [2.2, 3, np.nan]}, dtype="float32")
result = df.sum(**kwargs).dtype
assert result == "float32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the whole DataFrame and parametrize over all possible float dtypes.


def test_sum_object(self, float_frame):
values = float_frame.values.astype(int)
frame = DataFrame(values, index=float_frame.index, columns=float_frame.columns)
Expand Down