Skip to content

BUG: Eval scopes ignoring empty dictionaries (#47084) #47085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 5, 2022
Merged

BUG: Eval scopes ignoring empty dictionaries (#47084) #47085

merged 16 commits into from
Jun 5, 2022

Conversation

Alex-Blade
Copy link
Contributor

@Alex-Blade Alex-Blade commented May 21, 2022 •
edited
Loading

closes #47084

@pep8speaks
Copy link

pep8speaks commented May 21, 2022 •
edited
Loading

Hello @Alex-Blade! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-06-04 10:38:38 UTC

@jreback jreback added this to the 1.5 milestone May 21, 2022
@jreback jreback added Bug expressions pd.eval, query labels May 21, 2022
@jreback
Copy link
Contributor

jreback commented May 21, 2022

looks ok, need to do precommit here (line length). can you add a whatsnew note for this.

@jreback jreback removed this from the 1.5 milestone May 21, 2022
@Alex-Blade
Copy link
Contributor Author

@github-actions pre-commit

@Alex-Blade
Copy link
Contributor Author

@jreback, to be honest, I don't really get how should I name the entry in the _whatsnew_150.bug_fixes section. Some of them are named according to classnames (Categorical - Bug in Categorical.view). Others imply an action during which users may encounter the bug (Indexing - Bug in loc.__getitem__). Is there a list of predefined sections perhaps?

@Alex-Blade Alex-Blade force-pushed the eval-scopes-security branch from 05b2941 to 4b21c88 Compare May 23, 2022 10:08
@Alex-Blade
Copy link
Contributor Author

Alex-Blade commented May 23, 2022 •
edited
Loading

UPD. Rebased and made an entry in Other section, by analogy with similar bug-fixes from previous versions

jreback
jreback requested changes May 25, 2022
View reviewed changes
@Alex-Blade Alex-Blade requested a review from jreback May 25, 2022 09:00
@Alex-Blade
Copy link
Contributor Author

@jreback, mind looking at it again?

@simonjayhawkins
Copy link
Member

@jreback, mind looking at it again?

@Alex-Blade ci is failing. reviewers (other than Jeff) are more likely to review PRs with green ci.

code checks and some pytables tests are failing.

@jreback since the issue suggested this as being an security concern, would we consider this for 1.4.x (once ci is green)?

jreback
jreback reviewed May 30, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do for 1.4.x

@simonjayhawkins simonjayhawkins added this to the 1.4.3 milestone May 30, 2022
@jreback
Copy link
Contributor

jreback commented May 30, 2022

see here: https://github.com/pandas-dev/pandas/runs/6660273116?check_suite_focus=true

looks like the precommit is failing

@Alex-Blade
Copy link
Contributor Author

@github-actions pre-commit

@Alex-Blade
Copy link
Contributor Author

Seems like Numpy Dev died by an accident on setup-miniconda stage

@Alex-Blade
Copy link
Contributor Author

Alex-Blade commented May 31, 2022 •
edited
Loading

These tests are painful... Two times they died because of numpy, and now a timeout...

@Alex-Blade Alex-Blade requested a review from jreback June 1, 2022 18:38
@Alex-Blade
Copy link
Contributor Author

@simonjayhawkins, it has passed the tests a few times in a row, I think it can be considered as ready

@jreback jreback merged commit 5246d13 into pandas-dev:main Jun 5, 2022
@jreback
Copy link
Contributor

jreback commented Jun 5, 2022

thanks @Alex-Blade very nice!

@jreback
Copy link
Contributor

jreback commented Jun 5, 2022

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 5, 2022
@Alex-Blade @meeseeksmachine
Backport PR pandas-dev#47085: BUG: Eval scopes ignoring empty diction…
cd56069 
…aries (pandas-dev#47084)
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 5, 2022
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 5, 2022

Could not push to auto-backport-of-pr-47085-on-1.4.x due to error, aborting.

simonjayhawkins pushed a commit that referenced this pull request Jun 6, 2022
@meeseeksmachine @Alex-Blade
Backport PR #47085 on branch 1.4.x (BUG: Eval scopes ignoring empty d…
34259fb 
…ictionaries (#47084)) (#47250)

Backport PR #47085: BUG: Eval scopes ignoring empty dictionaries (#47084)

Co-authored-by: Alex-Blade <[email protected]>
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@Alex-Blade @yehoshuadimarsky
BUG: Eval scopes ignoring empty dictionaries (pandas-dev#47084) (pand…
a0775e2 
…as-dev#47085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

Assignees
No one assigned
Labels
Bug expressions pd.eval, query
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.

BUG: eval and query ignore empty local_dict and global_dict
4 participants
@Alex-Blade @pep8speaks @jreback @simonjayhawkins