-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix set_sticky
background
#47082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a note for this, 1.5, styler section
cc @attack68 |
This is the best solution. LGTM |
LGTM, failure unrelated. Needs approval from @jreback to merge. |
Thanks @ShawnZhong |
I think this PR introduced a bit of a regression since it makes the background of the sticky row/column transparent, which makes it harder to read once you scroll to right/down. You can see the behaviour in the current docuemntation |
I think regression is too strong a word for this item, but generally I agree. The underlying issue was reopened and remains outstanding. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Inherit the
background-color
of the sticky elements from its parents (with proper color alternation between rows) instead of hard-coding it to white.Example:
For reference, #42072 introduced the
set_sticky
feature.