ENH: liboffsets support non-nano #47076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 22, 2022
| f"DateOffset subclass {type(self).__name__} " | ||
| "does not have a vectorized implementation" | ||
| ) | ||
| warnings.warn("'Offset.apply_index(other)' is deprecated. " |
There was a problem hiding this comment.
Probably need a whatsnew note about this since it appears DateOffset.apply_index is publicly documented:https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.tseries.offsets.DateOffset.apply_index.html
There was a problem hiding this comment.
the warning was previously issued in the decorator which this PR removed
mroeschke
approved these changes
May 22, 2022
There was a problem hiding this comment.
LGTM. If you could address #47076 (comment) in a follow up PR that would be great.
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* ENH: liboffsets support non-nano * fix non-mac buildS * mypy fixup * fix doctest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.