-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: merge datetime_to_datetime64 into array_to_datetime #47018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 4 commits into
pandas-dev:main
from
jbrockmendel:ref-array_to_datetime-2
May 21, 2022
Merged
REF: merge datetime_to_datetime64 into array_to_datetime #47018
jreback
merged 4 commits into
pandas-dev:main
from
jbrockmendel:ref-array_to_datetime-2
May 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks fine, can you merge master. cc @mroeschke |
Looks like doctests are failing, otherwise LGTM |
The failed doctest looks like the new behavior is just better than the old behavior.
|
Yup agreed. Looks like this example could be removed from the docstring |
Or rather, this example this doctest be corrected and added as a unit test |
@jbrockmendel looks like this is still failing the doc tests
|
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.