TST: Assign back multiple column to datetime #46982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests make sure when converting multiple columns to datetimes and when assiging back it remains as datetime not as unix date as mentioned in GH pandas-dev#20511.
parthi-siva
changed the title
mroeschke
reviewed
May 11, 2022
mroeschke
reviewed
May 11, 2022
mroeschke
added
the
Testing
mroeschke
reviewed
May 11, 2022
pandas/tests/indexing/test_iloc.py
Outdated
| @@ -1363,6 +1382,25 @@ def test_frame_iloc_setitem_callable(self): | |||
| exp.iloc[[1, 3], [0]] = [-5, -5] | |||
| tm.assert_frame_equal(res, exp) | |||
|
|
|||
| def test_frame_iloc_setitem_callable_multicolumn_to_datetime( | |||
There was a problem hiding this comment.
I don't think this test is needed? It looks similar to the other test.
There was a problem hiding this comment.
I have used apply to convert to datetime. Yeah it's kind of look similar. Removed
jreback
added
the
Indexing
|
thanks @parthi-siva |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests make sure when converting multiple columns to datetimes
and when assiging back it remains as datetime not as unix date
as mentioned in GH #20511.