CLN: mmap used by only read_csv #46967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
May 7, 2022
| else: | ||
| # Binary mode | ||
| handle = open(handle, mode) | ||
| handle = open(handle, "rb") |
There was a problem hiding this comment.
mmap is used only for reading and there should be no point in opening the file in text mode as mmap should bypass that.
jreback
reviewed
May 8, 2022
| if encoding and "b" not in mode: | ||
| # Encoding | ||
| handle = open(handle, mode, encoding=encoding, errors=errors, newline="") | ||
| else: |
There was a problem hiding this comment.
any tests validate this? (nbd if you can't come up with an example, but ideally)
There was a problem hiding this comment.
This encoding+memory_map test should test it:
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clear that mmap is only ever used by
read_csv.