TYP: overload asarray_tuplesafe signature #46966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasoon
force-pushed
the
typing/asarray_tuplesafe
branch
2 times, most recently
from
77f53d3 to
735ee3b
Compare
iasoon
commented
May 7, 2022
| def asarray_tuplesafe(values, dtype: NpDtype | None = None) -> np.ndarray: | ||
| @overload | ||
| def asarray_tuplesafe( | ||
| values: ArrayLike | list | tuple | zip, dtype: NpDtype | None = ... |
There was a problem hiding this comment.
Alternatively to special-casing, we could omit zip here and have the caller convert the argument to a list first, instead of having this function do the conversion (currently there is one call site using zip).
There was a problem hiding this comment.
I'm fine with having zip here.
twoertwein
reviewed
May 7, 2022
twoertwein
approved these changes
May 8, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715