-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: fix a few annotations in offsets.pyi #46920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked your changes against current API. Did not check if there are others that need fixing - assume you did that. Small changes to make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a minor thing, but you have this:
holidays: None | list = ...,
calendar: np.busdaycalendar | None = ...,
Have we standardized on whether we put None
last or first? If not, we should be consistent within this file.
Not that I'm aware of. The only example I found is here: https://pandas.pydata.org/docs/development/contributing_codebase.html#style-guidelines (None at the end). |
I think we use the style of |
Thanks @twoertwein |
* TYP: fix a few annotations in offsets.pyi * variation + calendar * None at the end
Some doc-strings refer to
pd.HolidayCalendar
but that doesn't seem to exist?!There are a few more un-annotated variables and a few containers (list and dict) without types but I'm not familair enough with them to annotate them.