TYP: fix MultiIndex._names type #46919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasoon
force-pushed
the
typing/multiindex_names
branch
from
dc89867 to
2590553
Compare
iasoon
force-pushed
the
typing/multiindex_names
branch
from
2590553 to
1f33af4
Compare
|
thanks @iasoon |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715
_names was never really a FrozenList.
Also adapted some related code in _count_level
The change in _count_level is required because
listcannot be indexed byHashable- this issue had not been detected by mypy up until now because the argument of__getitem__is untyped forFrozenList.