REF: stronger typing in _box_func #46917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
mroeschke
reviewed
May 1, 2022
| @@ -367,19 +366,23 @@ def _wrap_results(result, dtype: np.dtype, fill_value=None): | |||
| result = np.datetime64("NaT", "ns") | |||
| else: | |||
| result = np.int64(result).view("datetime64[ns]") | |||
| # retain original unit | |||
| result = result.astype(dtype, copy=False) | |||
There was a problem hiding this comment.
So do these changes make things internally More Correct and not necessarily have an external behavior change?
There was a problem hiding this comment.
not user-facing unless they are directly using nanops, which they shouldnt be
jreback
reviewed
May 2, 2022
| # expected "Union[SupportsInt, Union[str, bytes], SupportsIndex]" | ||
| x = np.int64(x) # type: ignore[arg-type] | ||
| ts = Timestamp(x, tz=self.tz) | ||
| def _box_func(self, x: np.datetime64) -> Timestamp | NaTType: |
There was a problem hiding this comment.
is this guaranteed true? e.g. can the input be a Timestamp
There was a problem hiding this comment.
the nanops changes fix the only places where we call _box_func with incorrect scalars
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for non-nano support