Skip to content

DOC: fix rsplit doc #46835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2022
Merged

DOC: fix rsplit doc #46835

merged 2 commits into from
Apr 23, 2022

Conversation

dykim29
Copy link
Contributor

@dykim29 dykim29 commented Apr 22, 2022

Gets rid of the regex argument in .str.rsplit. The docs for .str.split remains unchanged

Screenshot 2022-04-22 at 14 07 54

Screenshot 2022-04-22 at 14 10 55

@pep8speaks
Copy link

pep8speaks commented Apr 22, 2022

Hello @dykim29! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-23 08:02:59 UTC

@dykim29 dykim29 force-pushed the fix_rsplit_doc branch 2 times, most recently from 5ee6cfa to b45290a Compare April 22, 2022 13:02
@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Apr 22, 2022
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me pending green, thanks @dykim29 !

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, now the validation's fixed - all good, the test error is unrelated

@MarcoGorelli MarcoGorelli merged commit d577d5d into pandas-dev:main Apr 23, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
* fix rsplit doc

* split out examples

Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: remove regex argument from .str.rsplit docs
3 participants