DOC: building page for nested methods doesn't work

[MarcoGorelli]

closes #46804

Like this

 python make.py clean && python make.py --single pandas.Series.str.rsplit

and

 python make.py clean && python make.py --single pandas.Series.value_counts

and

 python make.py clean && python make.py --single pandas.Series

have their docs built fine

cc @jorisvandenbossche

I didn't find any tests for building docs - are they just tested manually?

[mroeschke]

So this works locally for you? (Doc build passed which is promising)

[MarcoGorelli]

Yup, worked for a contributor too

I'll see if I can put a quick check for this together

[MarcoGorelli]

Doc build passed which is promising

Building with --single wasn't previous tested though, so it would've passed anyway 😄 Have added a quick check for it to the doc build job

[mroeschke]

Very nice! Thanks @MarcoGorelli

[rhshadrach]

@MarcoGorelli - running the code_checks locally, I now get some docs opening up in my browser:

pandas/doc/make.py

Lines 236 to 242 in c5610d2

	if ret_code == 0:
	if self.single_doc_html is not None:
	self._open_browser(self.single_doc_html)
	else:
	self._add_redirects()
	if self.whatsnew:
	self._open_browser(os.path.join("whatsnew", "index.html"))

I don't think this was intentional, right? No much of an issue, more of an oddity. Could we add an argument, e.g. --open-browser that when unspecified gives current behavior and when specified overrides? Then we could do open-browser=False in the code checks.

[MarcoGorelli]

Hey @rhshadrach

I don't think this was intentional, right?

that's right

how about

    argparser.add_argument(
        "--no-browser", help="Don't open browser", action="store_true"
    )

which, if passed, won't open the browser, and if not passed, retains the current behaviour?