-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Create ArrowDtype #46774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Create ArrowDtype #46774
Conversation
discussed on the March call, id like to migrate from BaseMaskedDtype/NumericDtype etc to just MaskedDtype. Similarly id suggest here just ArrowDtype. |
By "just ArrowDtype" you mean have |
Right, without all the subclasses |
pandas/core/arrays/arrow/base.py
Outdated
from pandas.core.arrays.arrow import ArrowExtensionArray | ||
|
||
|
||
class ArrowDtype(StorageExtensionDtype): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the dtypes here? shouldn't these be in pandas/core/dtypes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of consolidating all arrow related functionality under /arrays/arrow/
. Thoughts @jbrockmendel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no objection. Might be worth keeping something in core.dtypes.dtypes for dependency-structure purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fair, looking to keep these separate as much as possible, maybe rename this to _dtype.py at some point.
can we rename NumericDtype -> NumericMaskedDtype (alt maybe NumericNumpyDtype and rename BaseMaskedDtype) |
This PR will just add the base ArrowDtype for now |
Not activated yet. Opening to get any feedback about the approach cc @jbrockmendel