Skip to content

ENH: Create ArrowDtype #46774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2022
Merged

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Apr 14, 2022

Not activated yet. Opening to get any feedback about the approach cc @jbrockmendel

@mroeschke mroeschke added the Arrow pyarrow functionality label Apr 14, 2022
@jbrockmendel
Copy link
Member

discussed on the March call, id like to migrate from BaseMaskedDtype/NumericDtype etc to just MaskedDtype. Similarly id suggest here just ArrowDtype.

@mroeschke
Copy link
Member Author

By "just ArrowDtype" you mean have ArrowDtype inherit directly from ExtensionDtype?

@jbrockmendel
Copy link
Member

By "just ArrowDtype" you mean have ArrowDtype inherit directly from ExtensionDtype?

Right, without all the subclasses

@mroeschke mroeschke changed the title ENH: Create BaseArrowDtype & NumericArrowDtype ENH: Create ArrowDtype Apr 18, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 18, 2022
from pandas.core.arrays.arrow import ArrowExtensionArray


class ArrowDtype(StorageExtensionDtype):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the dtypes here? shouldn't these be in pandas/core/dtypes ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of consolidating all arrow related functionality under /arrays/arrow/. Thoughts @jbrockmendel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objection. Might be worth keeping something in core.dtypes.dtypes for dependency-structure purposes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fair, looking to keep these separate as much as possible, maybe rename this to _dtype.py at some point.

@jreback
Copy link
Contributor

jreback commented Apr 26, 2022

Not activated yet. Opening to get any feedback about the approach cc @jbrockmendel

  1. BaseArrowDtype inherits from BaseMaskedDtype
  2. NumericArrowDtype mirrors NumericDtype

can we rename NumericDtype -> NumericMaskedDtype (alt maybe NumericNumpyDtype and rename BaseMaskedDtype)

@mroeschke
Copy link
Member Author

Not activated yet. Opening to get any feedback about the approach cc @jbrockmendel

  1. BaseArrowDtype inherits from BaseMaskedDtype
  2. NumericArrowDtype mirrors NumericDtype

can we rename NumericDtype -> NumericMaskedDtype (alt maybe NumericNumpyDtype and rename BaseMaskedDtype)

This PR will just add the base ArrowDtype for now

@jreback jreback merged commit d37643a into pandas-dev:main May 2, 2022
@mroeschke mroeschke deleted the ci/targeted_pyarrow branch May 2, 2022 21:36
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants