BUG: Prevent segfault in roll_weighted_var #46772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Apr 14, 2022
mroeschke
reviewed
Apr 14, 2022
|
Ok, thanks. I'm unsure how to verify that my test I added to |
mroeschke
reviewed
Apr 14, 2022
mroeschke
reviewed
Apr 14, 2022
joseortiz3
changed the title
mroeschke
approved these changes
Apr 15, 2022
|
Awesome, thanks @joseortiz3 (the failure was unrelated) |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* Change range to prevent segfault See pandas-dev#46760 * Update v1.5.0.rst with doc of fix for issue 46760 * typo * Improve language for fix of weighted variance segfault * Added test for issue pandas-dev#46772 * style - change single quotes to double * Add fixtures `win_types` and `center` to test signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_win_type.pydoc/source/whatsnew/v1.5.0.rstfile because this fixes a bug