CI: Fail Numpy Dev build on DeprecationWarnings from numpy only #46767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +61,7 @@ jobs: | |||
| env_file: actions-310-numpydev.yaml | |||
| pattern: "not slow and not network and not single_cpu" | |||
| pandas_testing_mode: "deprecate" | |||
| test_args: "-W error" | |||
| test_args: "-W error::DeprecationWarning:numpy" | |||
There was a problem hiding this comment.
will this still catch FutureWarnings that we issue?
There was a problem hiding this comment.
Nope, only the DeprecationWarnings from numpy. Do we want to fail the build on our FutureWarnings?
There was a problem hiding this comment.
its possible we want to (but not this PR)
|
backport? |
mroeschke
changed the title
Yup probably a good idea |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Apr 14, 2022
…Warnings from numpy only
lithomas1
pushed a commit
that referenced
this pull request
Apr 14, 2022
…rom numpy only (#46773) Co-authored-by: Matthew Roeschke <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the intent of
-W errorwas to catch DeprecationWarnings from numpy primarily. Currently builds are failing because of a warning from distutils which idk if we can do anything about.