Skip to content

TST: Add a test for series name should be preserved in pser.mode() #46746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2022
Merged

TST: Add a test for series name should be preserved in pser.mode() #46746

merged 2 commits into from
Apr 13, 2022

Conversation

Yikun
Copy link
Contributor

@Yikun Yikun commented Apr 12, 2022 •
edited
Loading

Add a test for pser.mode() should set series name

@Yikun Yikun changed the title TST: Add a test for pser.mode() should set series name TST: Add a test for pser.mode() should preserved series name Apr 12, 2022
@Yikun Yikun changed the title TST: Add a test for pser.mode() should preserved series name TST: Add a test for series name should be preserved in pser.mode() Apr 12, 2022
@jreback jreback added Testing pandas testing functions or related to the test suite Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff metadata _metadata, .attrs labels Apr 13, 2022
@Yikun
Copy link
Contributor Author

Yikun commented Apr 13, 2022

@mroeschke Done, thanks!

@mroeschke mroeschke added this to the 1.5 milestone Apr 13, 2022
@mroeschke mroeschke merged commit 0d07c23 into pandas-dev:main Apr 13, 2022
@mroeschke
Copy link
Member

Excellent, thanks @Yikun

(Failure unrelated)

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@Yikun @yehoshuadimarsky
TST: Add a test for series name should be preserved in pser.mode() (…
a8e80b0 
…pandas-dev#46746)

* Add a test for Series.name preserved in ser.mode

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff metadata _metadata, .attrs Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: pser.mode() should not be set series name
3 participants
@Yikun @mroeschke @jreback