DOC: Improve .at indexer API docs #46734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this sounds fine |
FactorizeD
force-pushed
the
doc-clarify-at-indexer-api-docs
branch
from
2c8c355 to
4d153bb
Compare
mroeschke
reviewed
Apr 12, 2022
FactorizeD
force-pushed
the
doc-clarify-at-indexer-api-docs
branch
from
4d153bb to
a5044f6
Compare
|
Hello @FactorizeD! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-10 18:54:56 UTC |
FactorizeD
force-pushed
the
doc-clarify-at-indexer-api-docs
branch
2 times, most recently
from
3003c61 to
841f4f1
Compare
|
Failing check seems not related tot his PR. Can this be merged in the current state after the check issue is resolved, or should I do something more? |
mroeschke
reviewed
Apr 15, 2022
pandas/core/indexing.py
Outdated
| Notes | ||
| ----- | ||
| See `Fast scalar value getting and setting | ||
| <https://pandas.pydata.org/docs/dev/user_guide/indexing.html\ |
There was a problem hiding this comment.
Could you use :ref:`Fast scalar value getting and setting <indexing.basics.get_value>` instead?
FactorizeD
force-pushed
the
doc-clarify-at-indexer-api-docs
branch
from
841f4f1 to
dc2e0ee
Compare
mroeschke
approved these changes
Jun 3, 2022
|
Thanks @FactorizeD (sorry for the delay). Failure was unrelated |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
GH46722 Co-authored-by: Mateusz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the wording of the
ValueErrorand whether it is worth adding the additional methods underSee Alsobut the same doc is used for both DataFrame and Series so I thought that mentioning all the methods is good for the sake of completeness