Skip to content

Backport PR #46633 on branch 1.4.x (CI: Remove grep from asv call (using strict parameter instead)) #46727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2022
Merged

Backport PR #46633 on branch 1.4.x (CI: Remove grep from asv call (using strict parameter instead)) #46727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feee808
CI: Simplify call to asv (#46599)
datapythonista Apr 3, 2022
c061dcc
CI: Remove grep from asv call (using strict parameter instead) (#46633)
datapythonista Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,22 +140,8 @@ jobs:
- name: Run ASV benchmarks
run: |
cd asv_bench
asv check -E existing
git remote add upstream https://github.com/pandas-dev/pandas.git
git fetch upstream
asv machine --yes
asv dev | sed "/failed$/ s/^/##[error]/" | tee benchmarks.log
if grep "failed" benchmarks.log > /dev/null ; then
exit 1
fi
if: ${{ steps.build.outcome == 'success' }}

- name: Publish benchmarks artifact
uses: actions/upload-artifact@v3
with:
name: Benchmarks log
path: asv_bench/benchmarks.log
if: failure()
asv run --quick --dry-run --strict --durations=30 --python=same

build_docker_dev_environment:
name: Build Docker Dev Environment
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
- pytz

# benchmarks
- asv < 0.5.0 # 2022-02-08: v0.5.0 > leads to ASV checks running > 3 hours on CI
- asv

# building
# The compiler packages are meta-packages and install the correct compiler (activation) packages on the respective platforms.
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
numpy>=1.18.5
python-dateutil>=2.8.1
pytz
asv < 0.5.0
asv
cython>=0.29.24
black==22.3.0
cpplint
Expand Down