Skip to content

DOC/CLN: pd.test #46714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2022
Merged

DOC/CLN: pd.test #46714

merged 5 commits into from
Apr 9, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Apr 9, 2022
@mroeschke mroeschke added this to the 1.5 milestone Apr 9, 2022
@rhshadrach
Copy link
Member

rhshadrach commented Apr 9, 2022

hypothesis is imported unconditionally within the tests; won't that make pytest collection fail if it's not available? Similarly, pytest is still listed as a required dependency, why do optional import?

@mroeschke
Copy link
Member Author

hypothesis is imported unconditionally within the tests; won't that make pytest collection fail if it's not available?

I believe so, yes

pytest is still listed as a required dependency, why do optional import?

I don't think it's listed as a required dependency to install pandas (not that I can find), but it is required to run pd.test so I think that makes pytest an optional dependency.

@jreback
Copy link
Contributor

jreback commented Apr 9, 2022

yep this looks right.

@jreback jreback merged commit afbe1ed into pandas-dev:main Apr 9, 2022
@mroeschke mroeschke deleted the enh/test branch April 10, 2022 00:08
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants