Skip to content

DOC: sample variance -> population variance (#46482) #46711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2022

Conversation

kwhkim
Copy link
Contributor

@kwhkim kwhkim commented Apr 9, 2022

@jreback jreback added this to the 1.5 milestone Apr 10, 2022
@jreback jreback added the Docs label Apr 10, 2022
@@ -367,7 +367,7 @@ integer arrays to floating when NAs must be introduced.
Differences with NumPy
----------------------
For :class:`Series` and :class:`DataFrame` objects, :meth:`~DataFrame.var` normalizes by
``N-1`` to produce unbiased estimates of the sample variance, while NumPy's
``N-1`` to produce unbiased estimates of the population variance, while NumPy's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we also put the appropriate wiki link here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. for those who are confused with sample and population variance

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you merge in the main branch one more time?

@kwhkim
Copy link
Contributor Author

kwhkim commented Apr 26, 2022

@mroeschke sorry i dont understand what you mean.... you mean another pull request?

@jreback
Copy link
Contributor

jreback commented Apr 26, 2022

@mroeschke sorry i dont understand what you mean.... you mean another pull request?

no what you did is fine

@jreback jreback merged commit f706fc9 into pandas-dev:main Apr 27, 2022
@jreback
Copy link
Contributor

jreback commented Apr 27, 2022

thanks @kwhkim

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: sample variance -> population variance
3 participants