TYP: Make temporary variables in pandas/__init__.py private #46698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-06 23:21:07 UTC |
twoertwein
commented
Apr 8, 2022
twoertwein
commented
Apr 8, 2022
|
changes to |
I kept the simply changes in this PR and will later open a new PR for the remaining changes. |
|
@jreback green |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny step towards #39813 (
pyright --ignoreexternal --verifytypes pandas) the relevant changes are inpandas/__init__.pyandpandas/_config/config.py(private butget_option, ... uses the annotated wrapper).I didn't plan to do the second commit (seemingly unrelated changes) but it seems that the first commit disturbed mypy's slumber (probably a few more cases that used the un-annotated wrapper?). I'm not very confident in the changes from the second commit (types for cython/c functions).