-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI fix ci-failure from bs4 new version #46692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -577,7 +577,7 @@ def _parse_tables(self, doc, match, attrs): | |||
for elem in table.find_all(style=re.compile(r"display:\s*none")): | |||
elem.decompose() | |||
|
|||
if table not in unique_tables and table.find(text=match) is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this backwards compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was introduced in version 4.4.0, and the minimum version in pandas is 4.8.2, so should be fine
can u close/open again as the doc build failed to run |
It seems that the doc build also fails on master, but this seems to be unrelated |
yes that's unrelated, this only addresses the Posix / actions-38.yaml job |
that has been fixed in pandas-dev/pandas#46692
that has been fixed in pandas-dev/pandas#46692
that has been fixed in pandas-dev/pandas#46692
Co-authored-by: Marco Edward Gorelli <[email protected]>
New BS4 release is throwing a deprecation warning
From the docs