TST: Regression test added for Timedelta #46645
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Timedelta
jreback
requested changes
Apr 10, 2022
| @@ -1107,3 +1107,15 @@ def test_compare_complex_dtypes(): | |||
|
|
|||
| with pytest.raises(TypeError, match=msg): | |||
| df.lt(df.astype(object)) | |||
|
|
|||
|
|
|||
| def test_categorical_of_booleans_is_boolean(): | |||
There was a problem hiding this comment.
this is unrelated, please merge master
| ) | ||
| try: | ||
| for _, row in df.iterrows(): | ||
| row |
There was a problem hiding this comment.
don't put a try/except in a test.
also compare row here
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Thanks for the pull request, but it appears to be stale. If interested in continuing, please merge in the main branch, address the review, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.The commit on Mar 18 is approved. Not sure why it is showing up here... You can see it here:
#46422
This PR adds a regression test for #35665 , which was caused by #38965. Please let me know if there's more I need to do! Thanks!