Skip to content

TYP: na_value #46603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2022
Merged

TYP: na_value #46603

merged 2 commits into from
Apr 30, 2022

Conversation

twoertwein
Copy link
Member

na_value can in most cases be anything (object)

@rhshadrach rhshadrach added the Typing type annotations, mypy/pyright type checking label Apr 29, 2022
rhshadrach
rhshadrach approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you merge main

@rhshadrach rhshadrach added this to the 1.5 milestone Apr 29, 2022
@jreback jreback merged commit f9810c7 into pandas-dev:main Apr 30, 2022
@jreback
Copy link
Contributor

jreback commented Apr 30, 2022

thanks @twoertwein

@twoertwein twoertwein deleted the na_value branch May 26, 2022 01:59
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@twoertwein @yehoshuadimarsky
TYP: na_value (pandas-dev#46603)
2ab5c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@twoertwein @jreback @rhshadrach