-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI/TST: Make test_vector_resize more deterministic #46602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
moving to 1.4.3 no problem to merge to main as autobackport is disabled for 1.4.3 |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@meeseeksdev backport 1.4.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
(cherry picked from commit bea02f3)
#46350 was not backported (which this PR fixes), neither was the refactor #46106 that prevented the autobackport from succeeding and made some code changes to pandas/_libs/hashtable_class_helper.pxi.in that we probably don't want to backport (and maybe the reason #46350 was needed?) change the milestone on this to 1.5 and close the backport PR #46625? |
Sounds good to me. This doesn't fail often so hopefully it shouldn't affect the 1.4.x branch too often. |
will keep an eye out but I was thinking that it was maybe #46106 is the cause of the issue which would not affect 1.4.x anyway. |
I had to
xfail(strict=True)
this test once before which leads me to believe that the initial random data may be causing this test to be flaky.https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=76111&view=logs&jobId=b1891a80-bdb0-5193-5f59-ce68a0874df0&j=b1891a80-bdb0-5193-5f59-ce68a0874df0&t=0a58a9e9-0673-539c-5bde-d78a5a3b655e