Skip to content

POC For docker compose #46570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

POC For docker compose #46570

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6963520
first step at docker in CI
WillAyd Mar 30, 2022
b63d542
fixed issues except for permissions
WillAyd Mar 30, 2022
c4322b2
Merge remote-tracking branch 'upstream/main' into docker-compose
WillAyd Apr 1, 2022
8fb7297
separate services for db testing
WillAyd Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ci/docker/pandas-db-test.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
FROM python

RUN apt-get update
RUN apt-get install -y postgresql postgresql-contrib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason to install & configure postgres in this image instead of using the official postgres image?

services:
    postgres:
        image: postgres
        ....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the Postgres image includes Python, but even if it does longer term we may want to parametrize different versions of Python. We can parametrize the base Python image to build off of, but if we wanted to use Postgres as a base image we'd have to set up more layers to have that work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was imagine something closer to

services:
  pandas-testing:
     build: pandas-container.dockerfile
     command: pytest ...
  postgres-db:
    image: postgres
    ports:
      "5432":"5432"
  mysql-db:
    image: mysql
    ports:
       ...
  s3:
    image: motoserver/moto
    ports:
       ...

such postgres is an independently running service that the testing service can talk to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - didn't even know this was possible. Will test it out


USER postgres
RUN /etc/init.d/postgresql start && \
createdb pandas && \
psql -c "ALTER USER postgres PASSWORD 'postgres';"

USER root
RUN python -m pip install --upgrade pip
RUN python -m pip install \
cython \
hypothesis \
numpy \
psycopg2 \
pytest \
pytest-asyncio \
python-dateutil \
pytz \
sqlalchemy

WORKDIR /pandas

8 changes: 8 additions & 0 deletions ci/scripts/run-db-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/bash

set -e

python setup.py build_ext --inplace -j4

/etc/init.d/postgresql start
python -m pytest pandas/tests/io/test_sql.py
9 changes: 9 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
services:
db-testing:
build:
context: .
dockerfile: ci/docker/pandas-db-test.dockerfile
volumes:
- .:/pandas
command: /pandas/ci/scripts/run-db-tests.sh