Skip to content

Close FastParquet file even on error #46556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 30, 2022
Merged

Close FastParquet file even on error #46556

merged 8 commits into from
Mar 30, 2022

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Mar 29, 2022 •
edited
Loading

@twoertwein twoertwein added the IO Parquet parquet, feather label Mar 29, 2022
jreback
jreback requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to need a whatsnew note in I/O for 1.5

@flying-sheep flying-sheep requested a review from jreback March 30, 2022 14:51
@flying-sheep
Copy link
Contributor Author

going to need a whatsnew note in I/O for 1.5

done!

twoertwein
twoertwein approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny (non-essential) comments, looks good to me otherwise! Thanks @flying-sheep

@pep8speaks
Copy link

pep8speaks commented Mar 30, 2022 •
edited
Loading

Hello @flying-sheep! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-30 15:25:57 UTC

@jreback jreback added this to the 1.5 milestone Mar 30, 2022
@jreback jreback merged commit 8808db8 into pandas-dev:main Mar 30, 2022
@jreback
Copy link
Contributor

jreback commented Mar 30, 2022

thanks @flying-sheep

@flying-sheep flying-sheep deleted the patch-2 branch March 30, 2022 21:07
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@flying-sheep @yehoshuadimarsky
Close FastParquet file even on error (pandas-dev#46556)
d446375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
IO Parquet parquet, feather
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: read_parquet leaks file handles on error
4 participants
@flying-sheep @pep8speaks @jreback @twoertwein