Speed up a test #46547
Closed
Speed up a test #46547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 28, 2022
| @@ -759,9 +759,11 @@ def test_to_csv_chunking(self, chunksize): | |||
| tm.assert_frame_equal(rs, aa) | |||
|
|
|||
| @pytest.mark.slow | |||
| def test_to_csv_wide_frame_formatting(self): | |||
| def test_to_csv_wide_frame_formatting(self, monkeypatch): | |||
There was a problem hiding this comment.
this is a specific regression test #8621
i dont' think changing this is actually helping. (sure it helps in the running of the test but breaks the regression checking).
jreback
added
Testing
|
thanks @jonashaag all for faster tests, but we also cannot change them like this (which doesn't really test much). I basically am always -1 on monkey patching as it 99% of the time doesnt' catch anything. |
|
Actually my version of the test fails before the #8621 fix, I double checked. So it actually tests the bug, just with a smaller number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves 30s of test time, it ain't much but it's honest work :-) Also moves a magic number to a constant.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.