Skip to content

CI: xfail geopandas downstream test on Windows due to fiona install #46536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

mroeschke
Copy link
Member

Similar to #46296 but now happening on Windows

    def _check_fiona(func):
        if fiona is None:
>           raise ImportError(
                f"the {func} requires the 'fiona' package, but it is not installed or does "
                f"not import correctly.\nImporting fiona resulted in: {fiona_import_error}"
            )
E           ImportError: the 'read_file' function requires the 'fiona' package, but it is not installed or does not import correctly.
E           Importing fiona resulted in: DLL load failed while importing ogrext: The specified procedure could not be found.

cc @jorisvandenbossche can this downstream test be changed to not go through fiona?

@mroeschke mroeschke added CI Continuous Integration Dependencies Required and optional dependencies labels Mar 27, 2022
@jreback jreback added this to the 1.5 milestone Mar 28, 2022
@jreback jreback merged commit ccfd0d6 into pandas-dev:main Mar 28, 2022
@jreback
Copy link
Contributor

jreback commented Mar 28, 2022

@simonjayhawkins possibliy this is needed for 1.4.x but can wait and see if the package is fixed

@mroeschke mroeschke deleted the ci/geopandas branch March 28, 2022 17:09
@jorisvandenbossche
Copy link
Member

can this downstream test be changed to not go through fiona?

It's a bit unfortunate that such a breakage happened twice in a really short time. Generally it doesn't happen that often, but of course will also never be guaranteed to not happen ..

For the test itself, we could indeed change it to not use fiona (eg use pyarrow instead, which is already be installed anyway in that env).

Another option could also be to simply remove the test. In geopandas, we have a build that tests against pandas main, so that should also cover this (although that doesn't test exactly the same, since our downstream test is testing with released geopandas)

Will do a PR to remove the usage of fiona.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants