Skip to content

Revert "TYP: Many typing constructs are invariant" #46530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Revert "TYP: Many typing constructs are invariant" #46530

merged 1 commit into from
Mar 27, 2022

Conversation

twoertwein
Copy link
Member

@twoertwein twoertwein commented Mar 27, 2022

I accidentally pushed to pandas instead of my fork :(

Is it possible in github to disallow direct pushes to the repository (only allow PRs)?

edit: It seems that this is possible https://stackoverflow.com/a/57685576

@twoertwein
Copy link
Member Author

@jreback @simonjayhawkins

@jreback
Copy link
Contributor

jreback commented Mar 27, 2022

go ahead and merge when ready

i think can prevent merging directly to master

@jreback
Copy link
Contributor

jreback commented Mar 27, 2022

I protected the main branch from direct pushes.

@twoertwein
Copy link
Member Author

Some windows tests fail with:

ImportError: the 'read_file' function requires the 'fiona' package, but it is not installed or does not import correctly.
Importing fiona resulted in: DLL load failed while importing ogrext: The specified procedure could not be found.

Seems unrelated, but I am not going to merge this myself - messed up enough for today :(

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated, but I am not going to merge this myself

Agreed that it looks unrelated - happy to merge then as it's just a revert

messed up enough for today :(

Please don't be hard on yourself, I'm sure everyone appreciates your contributions to the community! 🙌

@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Mar 27, 2022
@MarcoGorelli MarcoGorelli added the Typing type annotations, mypy/pyright type checking label Mar 27, 2022
@MarcoGorelli MarcoGorelli merged commit 4cf6867 into pandas-dev:main Mar 27, 2022
@jreback
Copy link
Contributor

jreback commented Mar 27, 2022

yep yep totally fine @twoertwein

@twoertwein twoertwein deleted the revert branch April 1, 2022 01:36
@simonjayhawkins
Copy link
Member

I protected the main branch from direct pushes.

@jreback the release scripts do a direct push. for main this is only an issue for rc. Is 1.4.x protected?

@jreback
Copy link
Contributor

jreback commented Apr 2, 2022

nope other branches are not protected

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants