-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Revert "TYP: Many typing constructs are invariant" #46530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit fcab848.
go ahead and merge when ready i think can prevent merging directly to master |
I protected the main branch from direct pushes. |
Some windows tests fail with:
Seems unrelated, but I am not going to merge this myself - messed up enough for today :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep yep totally fine @twoertwein |
@jreback the release scripts do a direct push. for main this is only an issue for rc. Is 1.4.x protected? |
nope other branches are not protected |
This reverts commit fcab848.
I accidentally pushed to pandas instead of my fork :(
Is it possible in github to disallow direct pushes to the repository (only allow PRs)?
edit: It seems that this is possible https://stackoverflow.com/a/57685576