TYP: Fix core/groupby/generic.py type ignores #46521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
849d4ac to
060dc57
Compare
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
060dc57 to
82b9dae
Compare
twoertwein
reviewed
Mar 28, 2022
twoertwein
reviewed
Mar 28, 2022
twoertwein
reviewed
Mar 28, 2022
|
After reviewing all the comments it seems that the only change that can be applied at the moment is |
|
Thanks @FactorizeD can you get this PR into a mergeable state (and not marked as draft) even if only the one change. |
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
82b9dae to
d715868
Compare
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
d715868 to
cb32477
Compare
twoertwein
approved these changes
May 7, 2022
|
can you merge master and fix the precommit |
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
cb32477 to
52bece7
Compare
FactorizeD
force-pushed
the
typ-fix-core-groupby-generic-type-errors
branch
from
52bece7 to
0c06344
Compare
simonjayhawkins
approved these changes
May 11, 2022
There was a problem hiding this comment.
Thanks @FactorizeD ci failure for TestParquetPyArrow.test_unsupported unrelated (and now fixed on main)
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #37715
Two things to mention:
Index()in line 277 becausecolumnsattribute of a dataframe is supposed to be of Index type.