Skip to content

return nan on empty groups #46506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eytanohana
Copy link

I'm not sure where in the rst file to specify this behavior change. If its a bug fix or just an enhancement. Any help would be appreciated.

I also ran some of the test...apply files and they passed, please let me know what else I should do.
thank you!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - any PR fixing a bug needs to have tests. I think the fix here needs to be different, we do not want to return nan when an integer position is not found.

@rhshadrach rhshadrach added Bug Groupby Apply Apply, Aggregate, Transform, Map labels Apr 22, 2022
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label May 24, 2022
@rhshadrach
Copy link
Member

Closing this PR as stale. @eytanohana - respond here if you are interested in continuing and would be happy to reopen!

@rhshadrach rhshadrach closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Bug Groupby Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: lambda with positional references in apply after groupby on empty dataframe errors
2 participants