Skip to content

CI Clean up code #46502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2022
Merged

CI Clean up code #46502

merged 4 commits into from
Mar 25, 2022

Conversation

Mariam-ke
Copy link
Contributor

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
  • Worked on during pyladies london sprint, cleaned up code and added SS01

@MarcoGorelli MarcoGorelli self-requested a review March 25, 2022 11:58
MarcoGorelli
MarcoGorelli approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - CI error is unrelated, merging as the relevant check (validate docstrings) still passes

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Mar 25, 2022
@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Mar 25, 2022
@MarcoGorelli MarcoGorelli merged commit a5bc868 into pandas-dev:main Mar 25, 2022
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@Mariam-ke @MarcoGorelli @yehoshuadimarsky
CI Clean up code (pandas-dev#46502)
21e26e4 
* Cleaned up codes in validate_docstrings

* Remove comma

* Added SS01

* noop (trying to start CI)

Co-authored-by: Mariam-ke <[email protected]>
Co-authored-by: Marco Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariam-ke @MarcoGorelli