-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: tz_localize(UTC) not making a copy #46460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: tz_localize(UTC) not making a copy #46460
Conversation
I think thats the test that #46450 fixed |
times = ["2015-03-08 01:00", "2015-03-08 02:00", "2015-03-08 03:00"] | ||
index = DatetimeIndex(times) | ||
|
||
res = index.tz_localize("UTC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably good to test with utc_fixture
.
Also based on the code change None
also returns a copy now too (and should be tested)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. will use the fixture in the index tests and do the None just once in the tslibs tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warrants a whatsnew?
You may be aware, but looks like this PR didn't fully pass the CI checks
|
yah, #46478 includes a fix |
also #46489 is a targeted fix |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.