BUG: url regex in style_render does not pass colon and other valid
#46457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
requested changes
Mar 21, 2022
attack68
reviewed
Mar 21, 2022
| @@ -780,6 +780,8 @@ def test_hiding_index_columns_multiindex_trimming(): | |||
| ("ftp scheme: ftp://www.web", True, "ftp://www.web"), | |||
| ("subdirectories: www.web.com/directory", True, "www.web.com/directory"), | |||
| ("Multiple domains: www.1.2.3.4", True, "www.1.2.3.4"), | |||
| ("with port: http://web.com:80", True, "http://web.com:80"), | |||
| ("with anchor: http://web.com/anc#hor", True, "http://web.com/anc#hor"), | |||
There was a problem hiding this comment.
add all the special characters to this line so that they are tested simultaneously.
There was a problem hiding this comment.
Thanks, I made the tests more exhaustive and also tweaked the regex a little bit more.
URLs containing some valid characters such as colon in port numbers get cut off when html-formatting. As a workaround, expanded the regex to match a wider variety of URLs.
kianelbo
force-pushed
the
fix-href-render
branch
from
d688715 to
ba9cc9a
Compare
attack68
approved these changes
Mar 21, 2022
mroeschke
reviewed
Mar 22, 2022
jreback
added
Styler
mroeschke
approved these changes
Mar 23, 2022
simonjayhawkins
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Thanks @kianelbo for the PR.
minor change request to give the release note some context.
Co-authored-by: Simon Hawkins <[email protected]>
simonjayhawkins
approved these changes
Mar 24, 2022
|
Thanks @kianelbo |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 24, 2022
…ot pass colon and other valid
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Mar 25, 2022
…lon and other valid (#46497) Co-authored-by: Kian Eliasi <[email protected]>
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…andas-dev#46457) * BUG: url regex in `style_render` does not pass colon and other valid URLs containing some valid characters such as colon in port numbers get cut off when html-formatting. As a workaround, expanded the regex to match a wider variety of URLs. * Add whatsnew entry for pandas-dev#46389 fix * Update whatsnew entry for fix pandas-dev#46389 Co-authored-by: Simon Hawkins <[email protected]> Co-authored-by: Simon Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs containing some valid characters such as colon in port numbers get
cut off when html-formatting. As a workaround, expanded the regex to
match a wider variety of URLs.
doc/source/whatsnew/v1.4.2.rstfile if fixing a bug or adding a new feature.