Skip to content

REF: Eliminate another iterchunks call in ArrowExtensionArray #46448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

REF: Eliminate another iterchunks call in ArrowExtensionArray #46448

merged 3 commits into from
Mar 28, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 20, 2022 •
edited
Loading

Turns O(2n) -> O(n) over self._data.iterchunks() by combining creating indices + setting values

@mroeschke mroeschke requested a review from lukemanley March 20, 2022 19:43
lukemanley
lukemanley approved these changes Mar 20, 2022
View reviewed changes
Copy link
Member

@lukemanley lukemanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@mroeschke mroeschke added Indexing Related to indexing on series/frames, not to indexes themselves Arrow pyarrow functionality labels Mar 20, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 20, 2022
@jreback jreback merged commit e4b930a into pandas-dev:main Mar 28, 2022
@mroeschke mroeschke deleted the ref/arrowarray_setitem branch March 28, 2022 19:39
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
REF: Eliminate another iterchunks call in ArrowExtensionArray (pandas…
68982bb 
…-dev#46448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemanley lukemanley lukemanley approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @lukemanley @jreback