-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: drop #46423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYP: drop #46423
Conversation
@@ -297,6 +297,9 @@ def closed(self) -> bool: | |||
else: | |||
TakeIndexer = Any | |||
|
|||
# Shared by functions such as drop and astype | |||
IgnoreRaise = Literal["ignore", "raise"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added it to a few other functions (there might be more that only accept ignore/raise).
) -> NDFrameT | None: | ||
... | ||
|
||
@deprecate_nonkeyword_arguments(version=None, allowed_args=["self", "labels"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deprecation is new. Previously, this deprecation was only in Series/DataFrame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add a reference to the mypy issue you created so we can track it.
Tested with mypy and pyright: