CLN: assorted #46420
Merged
CLN: assorted #46420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Mar 18, 2022
pandas/_libs/tslibs/timedeltas.pxd
Outdated
| @@ -11,7 +11,6 @@ cdef bint is_any_td_scalar(object obj) | |||
| cdef class _Timedelta(timedelta): | |||
| cdef readonly: | |||
| int64_t value # nanoseconds | |||
| object freq # frequency reference | |||
There was a problem hiding this comment.
i guess this is an API change, could be done via a deprecation
There was a problem hiding this comment.
if OK, i'll revert and then deprecate in a follow-up.
There was a problem hiding this comment.
+1. Yeah appears this is never set.
IMO is_populated should be deprecated too and made private
mroeschke
reviewed
Mar 18, 2022
|
reverted Timedelta.freq removal, will do it The Right Way along with is_populated |
mroeschke
approved these changes
Mar 19, 2022
4 tasks
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.