TST: Additional tests to iloc setitem #46419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
jreback
requested changes
Mar 18, 2022
pandas/tests/indexing/test_iloc.py
Outdated
| expected = DataFrame( | ||
| {"A": to_datetime(["2021", "2022"]), "B": ["2021", "2022"]} | ||
| ) | ||
| tm.assert_frame_equal(df, expected, check_dtype=False) |
There was a problem hiding this comment.
Because the datatype remains as object after assign back. Not converted to datetime
>>> df = DataFrame({"A": ["2022-01-01", "2022-01-02"], "B": ["2021", "2022"]})
>>>
>>>
>>> df.iloc[:, [0]] = DataFrame({"A": to_datetime(["2021", "2022"])})
>>>
>>>
>>> df.dtypes
A object
B object
dtype: object
>>>
>>> df
A B
0 2021-01-01 00:00:00 2021
1 2022-01-01 00:00:00 2022
>>>
There was a problem hiding this comment.
then pls construct the exact expected series. this may actually be a bug
There was a problem hiding this comment.
After the assignment if we check the dtypes it shows as object
In [89]: df = DataFrame({"A": ["2022-01-01", "2022-01-02"], "B": ["2021", "2022"]})
In [90]: df.iloc[:, [0]] = df.iloc[:, [0]].apply(to_datetime)
In [91]: df.dtypes
Out[91]:
A object
B object
dtype: object
But if we use iat to take a look at one of the single value which is converted it show as Timestamp
In [92]: df.iat[0,0]
Out[92]: Timestamp('2022-01-01 00:00:00')
So constructed the exact expected frame using Timestamp and dtype as object
pandas/tests/indexing/test_iloc.py
Outdated
| expected = DataFrame( | ||
| {"A": to_datetime(["2022-01-01", "2022-01-02"]), "B": ["2021", "2022"]} | ||
| ) | ||
| tm.assert_frame_equal(df, expected, check_dtype=False) |
|
Hello @parthi-siva! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-04-28 15:06:16 UTC |
parthi-siva
force-pushed
the
TST_for_issue_#20511
branch
from
1eb2894 to
b33eb02
Compare
parthi-siva
commented
Mar 22, 2022
parthi-siva
changed the title
This tests make sure when converting multiple columns to datetimes and when assiging back it remains as datetime not as unix date as mentioned in GH pandas-dev#20511.
parthi-siva
force-pushed
the
TST_for_issue_#20511
branch
from
9cd71f1 to
f449fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests make sure when converting multiple columns to datetimes
and when assiging back it remains as datetime not as unix date
as mentioned in GH #20511.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.