BUG: Fixed Unicode decoding error in `Period.strftime` when a locale-specific directive is used#46405

Merged

mroeschke merged 60 commits intopandas-dev:mainfrom

smarie:feature/46319_locale_strftime_period

Sep 8, 2022

Commits on Mar 17, 2022

Added test representative of #46319. Should fail on CI
Sylvain MARIE
committed
Added a gha worker with non utf 8 zh_CN encoding
Sylvain MARIE
committed
Attempt to fix the encoding so that locale works
Sylvain MARIE
committed
Added the fix, but not using it for now, until CI is able to reproduce the issue.
Sylvain MARIE
committed

Commits on Mar 18, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Crazy idea: maybe simply removing the .utf8 modifier will use the right encoding !
Sylvain MARIE
committed
Hopefully fixing the locale not available error
Sylvain MARIE
committed
Now simply generating the locale, not updating the ubuntu one
Sylvain MARIE
committed
Trying to install the locale without enabling it
Sylvain MARIE
committed
Stupid mistake
Sylvain MARIE
committed

Commits on Mar 19, 2022

Testing the optional locale generator condition
Sylvain MARIE
committed
Put back all runners
Sylvain MARIE
committed
Added whatsnew
Sylvain MARIE
committed
Now using the fix
Sylvain MARIE
committed
As per code review: moved locale-switching fixture `overridden_locale` to conftest
Sylvain MARIE
committed
Flake8
Sylvain MARIE
committed
Added comments on the runner
Sylvain MARIE
committed

Commits on Mar 20, 2022

Added a non-utf8 locale in the `it_IT` runner. Added the zh_CN.utf8 locale in the tests
Sylvain MARIE
committed
Improved readability of fixture `overridden_locale` as per code review
Sylvain MARIE
committed

Commits on Mar 21, 2022

Added two comments on default encoding
Sylvain MARIE
committed
Fixed #46319 by adding a new `char_to_string_locale` function in the `tslibs.util` module, able to decode char* using the current locale.
Sylvain MARIE
committed
As per code review: modified the test to contain non-utf8 chars. Fixed the resulting issue.
Sylvain MARIE
committed
Split the test in two for clarity
Sylvain MARIE
committed
Fixed test and flake8 error.
Sylvain MARIE
committed
Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Mar 22, 2022

Updated whatsnew to ref #46468 . Updated test name
Sylvain MARIE
committed
Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Removing wrong whatsnew bullet
smarie
authored

Commits on Mar 23, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Nitpick on whatsnew as per code review
Sylvain MARIE
committed
Fixed build error rst directive
Sylvain MARIE
committed

Commits on Mar 24, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Mar 25, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Apr 1, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Names incorrectly reverted in last merge commit
Sylvain MARIE
committed
Fixed test_localization so that #46595 can be demonstrated on windows targets (even if today these do not run on windows targets, see #46597)
Sylvain MARIE
committed
Fixed `tm.set_locale` context manager, it could error and leak when category LC_ALL was used. Fixed #46595
Sylvain MARIE
committed
Removed the fixture as per code review, and added corresponding parametrization in tests.
Sylvain MARIE
committed
Dummy mod to trigger CI again
Sylvain MARIE
committed
reverted dummy mod
Sylvain MARIE
committed

Commits on Apr 7, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Apr 12, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Jul 1, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed

Commits on Jul 12, 2022

Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Attempt to fix the remaining error on the numpy worker
Sylvain MARIE
committed
Fixed issue in `_from_ordinal`
Sylvain MARIE
committed
Added asserts to try to understand
Sylvain MARIE
committed

Commits on Jul 13, 2022

Reverted debugging asserts and applied fix for numpy repeat from #47670.
Sylvain MARIE
committed
Fixed the last issue on numpy dev: a TypeError message had changed
Sylvain MARIE
committed

Commits on Jul 16, 2022

Merge branch 'main' into feature/46319_locale_strftime_period
smarie
authored

Commits on Sep 3, 2022

Code review: Removed `EXTRA_LOC`
Sylvain MARIE
committed
Code review: removed commented line
Sylvain MARIE
committed
Code review: reverted out of scope change
Sylvain MARIE
committed
Code review: reverted out of scope change
Sylvain MARIE
committed
Merge branch 'main' of https://github.com/pandas-dev/pandas into feature/46319_locale_strftime_period
Sylvain MARIE
committed
Fixed unused import
Sylvain MARIE
committed

Commits on Sep 6, 2022

Fixed revert mistake
Sylvain MARIE
committed
Moved whatsnew to 1.6.0
Sylvain MARIE
committed
Update pandas/tests/io/parser/test_quoting.py
smarie
authored
Merge branch 'main' into feature/46319_locale_strftime_period
smarie
authored