-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Use conda-forge PyPy #46394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use conda-forge PyPy #46394
Conversation
i guess this needs a rebase? |
@mattip It seems that the new PyPy release on conda-forge cannot find python packages installed from conda.
but can't be imported
I guess something is wrong with the Pythonpath on the conda pypy's. Interestingly enough, scripts that come with the packages can be found. |
The migration to start providing packages for pypy3.8 on conda-forge has not started yet. |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM can you merge in main one more time?
There are 615 failed tests. We are allowing failures on this job? (and just checking that pandas builds?) |
we don't have official support for pypy - ideally we xfail the failing tests and actually make the build fail on failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are allowing failures on this job? (and just checking that pandas builds?)
Yes there's a continue-on-error: ${{ env.IS_PYPY == 'true' }}
when the test are run.
I think addressing the testing behavior can be done in a follow up PR as this is a nice cleanup for how pypy is being setup in this build
For now, yes. This is probably helpful for conda-forge, as there is a PyPy build on there.
Will do in a follow up (This may take a while, though. I am a bit busy now). |
yep this all sounds great. @lithomas if you can make an issue (if we don't have alreadY). |
Thanks @lithomas1. yep. not intended to block. just seeking clarification of purpose of ci job. |
@meeseeksdev backport 1.4.x |
Co-authored-by: Thomas Li <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.