Skip to content

TST: skip -> xfail #46387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2022
Merged

TST: skip -> xfail #46387

merged 3 commits into from
Mar 17, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Mar 16, 2022

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Mar 16, 2022
@mroeschke mroeschke added this to the 1.5 milestone Mar 16, 2022
@jbrockmendel
Copy link
Member

@mroeschke ive started getting local test failures at collect-time with "ERROR: Unknown config option: asyncio_mode". commenting out the 'asyncio_mode = "strict"' line in pyproject.toml seems to fix it. Could this be related to any of the recent CI stuff you've been doing?

@mroeschke
Copy link
Member Author

@mroeschke ive started getting local test failures at collect-time with "ERROR: Unknown config option: asyncio_mode". commenting out the 'asyncio_mode = "strict"' line in pyproject.toml seems to fix it. Could this be related to any of the recent CI stuff you've been doing?

Hmm do you have pytest-asyncio in your virtual environment?

@jbrockmendel
Copy link
Member

Hmm do you have pytest-asyncio in your virtual environment?

Yes. should i get rid of it?

@mroeschke
Copy link
Member Author

Hmm odd I've seen the CI complain if it wasn't installed. What are your pytest & plugin versions? Or maybe it's a pytest cache issue?

(pandas-dev) ...  % pytest pandas --collect-only
========================================================= test session starts ==========================================================
platform darwin -- Python 3.8.12, pytest-7.0.0, pluggy-1.0.0
rootdir: /Users/... , configfile: pyproject.toml, testpaths: pandas
plugins: xdist-2.5.0, forked-1.4.0, cython-0.1.1.post0, hypothesis-6.36.1, instafail-0.4.1, asyncio-0.18.0, cov-3.0.0
asyncio: mode=strict

...
========================================== 166393 tests collected in 49.85s ===========================================

@jbrockmendel
Copy link
Member

looks like upgrading from 0.14..0 to 0.18.0 fixed it, thanks. sorry for derailing.

@jreback jreback merged commit 2dfe3a9 into pandas-dev:main Mar 17, 2022
@mroeschke mroeschke deleted the tst/skip_xfail branch March 18, 2022 00:31
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants