BUG: replace with value also being replaced #46335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
Regression
jreback
requested changes
Mar 12, 2022
jreback
reviewed
Mar 12, 2022
pandas/core/internals/blocks.py
Outdated
| type(self).replace, to_replace, value, inplace=True | ||
| ) | ||
| blocks = [] | ||
| nbs = self._split() |
There was a problem hiding this comment.
could write this entire section as a list-comprehension, but maybe not as readable
There was a problem hiding this comment.
good idea, i like the list comprehension better
There was a problem hiding this comment.
Went back to a non-list comprehension implementation as it requires unpacking.
|
@jreback - greenish |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 12, 2022
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Mar 12, 2022
Co-authored-by: Luke Manley <[email protected]>
| @@ -18,6 +18,7 @@ Fixed regressions | |||
| - Fixed regression in :func:`read_csv` killing python process when invalid file input was given for ``engine="c"`` (:issue:`45957`) | |||
| - Fixed memory performance regression in :meth:`Series.fillna` when called on a :class:`DataFrame` column with ``inplace=True`` (:issue:`46149`) | |||
| - Provided an alternative solution for passing custom Excel formats in :meth:`.Styler.to_excel`, which was a regression based on stricter CSS validation. Examples available in the documentation for :meth:`.Styler.format` (:issue:`46152`) | |||
| - Fixed regression in :meth:`DataFrame.replace` when a replacement value was also a target for replacement (:issue:`46335`) | |||
There was a problem hiding this comment.
will change the issue number to #46306 in a release note tidy up
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Mar 16, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.4.2.rst