Skip to content

Regression in read csv causing segfault for invalid file input #46325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2022
Merged

Regression in read csv causing segfault for invalid file input #46325

merged 3 commits into from
Mar 11, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 11, 2022

@phofl phofl added Regression Functionality that used to work in a prior pandas version Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv labels Mar 11, 2022
@phofl phofl added this to the 1.4.2 milestone Mar 11, 2022
jbrockmendel
jbrockmendel reviewed Mar 11, 2022
View reviewed changes
pandas/io/parsers/readers.py Outdated
@@ -1710,6 +1710,10 @@ def _make_engine(
assert self.handles is not None
f = self.handles.handle

elif not engine == "python":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick "!="?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, no idea why I was using the not syntax

jbrockmendel
jbrockmendel approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreback jreback merged commit e252dd7 into pandas-dev:main Mar 11, 2022
@jreback
Copy link
Contributor

jreback commented Mar 11, 2022

thanks @phofl

@jreback
Copy link
Contributor

jreback commented Mar 11, 2022

@meeseeksdev backport 1.4.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 11, 2022
@phofl @meeseeksmachine
Backport PR pandas-dev#46325: Regression in read csv causing segfault…
156c83d 
… for invalid file input
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 11, 2022
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Mar 11, 2022

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Mar 12, 2022
@meeseeksmachine @phofl
Backport PR #46325: Regression in read csv causing segfault for inval…
e11dba8 
…id file input (#46333)

Co-authored-by: Patrick Hoefler <[email protected]>
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 12, 2022
Closed
4 tasks
@mroeschke mroeschke mentioned this pull request Mar 17, 2022
Closed
3 tasks
@phofl phofl deleted the 45957 branch June 6, 2022 20:51
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@phofl @yehoshuadimarsky
Regression in read csv causing segfault for invalid file input (panda…
c09a9e1 
…s-dev#46325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.

Passing an empty list to read_csv causes segmentation fault
4 participants
@phofl @jreback @twoertwein @jbrockmendel